Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1939853002: Remove cast from AstNodeImpl._becomeParentOf (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+795 lines, -657 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 77 chunks +470 lines, -348 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 231 chunks +325 lines, -309 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-02 17:13:54 UTC) #2
scheglov
lgtm
4 years, 7 months ago (2016-05-02 17:18:15 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-05-02 17:21:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91e285265961a435e7af8e047df801cd20a0a7a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698