Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 8131cd473a759b5424de0fad0d0ac2d50dbc24b5..63effbc3a0500f52eeb2a5f564bf4bf0a8f0cdc1 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -44,8 +44,8 @@ from webkitpy.common.system.executive import ScriptError
from webkitpy.layout_tests.controllers.test_result_writer import TestResultWriter
from webkitpy.layout_tests.models import test_failures
from webkitpy.layout_tests.models.test_expectations import TestExpectations, BASELINE_SUFFIX_LIST, SKIP
-from webkitpy.layout_tests.port import builders
from webkitpy.layout_tests.port import factory
+from webkitpy.layout_tests.builders import Builders
from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
@@ -103,7 +103,7 @@ class BaseInternalRebaselineCommand(AbstractRebaseliningCommand):
def _baseline_directory(self, builder_name):
port = self._tool.port_factory.get_from_builder_name(builder_name)
- override_dir = builders.rebaseline_override_dir(builder_name)
+ override_dir = self._tool.builders.rebaseline_override_dir(builder_name)
if override_dir:
return self._tool.filesystem.join(port.layout_tests_dir(), 'platform', override_dir)
return port.baseline_version_dir()
@@ -345,7 +345,7 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
# The release builders cycle much faster than the debug ones and cover all the platforms.
def _release_builders(self):
release_builders = []
- for builder_name in builders.all_builder_names():
+ for builder_name in self._tool.builders.all_builder_names():
if builder_name.find('ASAN') != -1:
continue
port = self._tool.port_factory.get_from_builder_name(builder_name)
@@ -600,7 +600,7 @@ class RebaselineExpectations(AbstractParallelRebaselineCommand):
return tests_to_rebaseline
def _add_tests_to_rebaseline_for_port(self, port_name):
- builder_name = builders.builder_name_for_port_name(port_name)
+ builder_name = self._tool.builders.builder_name_for_port_name(port_name)
if not builder_name:
return
tests = self._tests_to_rebaseline(self._tool.port_factory.get(port_name)).items()
@@ -806,7 +806,7 @@ class AutoRebaseline(AbstractParallelRebaselineCommand):
lines_to_remove = {}
for builder_name in self._release_builders():
- port_name = builders.port_name_for_builder_name(builder_name)
+ port_name = self._tool.builders.port_name_for_builder_name(builder_name)
port = self._tool.port_factory.get(port_name)
expectations = TestExpectations(port, include_overrides=True)
for test in expectations.get_needs_rebaseline_failures():

Powered by Google App Engine
This is Rietveld 408576698