third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py - Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

index db878a06a86ae6f7bd6184b1bb9b875c0dbc4940..95ffcba59099cca79695aaf02dd708424daab2e0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -33,8 +33,6 @@ import optparse

import re

from webkitpy.common.webkit_finder import WebKitFinder

-from webkitpy.layout_tests.port import builders

def platform_options(use_globs=False):

return [

@@ -186,9 +184,9 @@ class PortFactory(object):

If platform is not specified, we will glob-match all ports"""

platform = platform or '*'

- return fnmatch.filter(builders.all_port_names(), platform)

+ return fnmatch.filter(self._host.builders.all_port_names(), platform)

def get_from_builder_name(self, builder_name):

- port_name = builders.port_name_for_builder_name(builder_name)

+ port_name = self._host.builders.port_name_for_builder_name(builder_name)

assert port_name, "unrecognized builder name '%s'" % builder_name

return self.get(port_name, _builder_options(builder_name))