third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders_unittest.py - Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders_unittest.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders_unittest.py

similarity index 96%

rename from third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py

rename to third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders_unittest.py

index ed8e9c166c61c2e3b67117547a219d342d15b8a1..b514212fd163a293dee5bd8772de0baffbf36599 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builders_unittest.py

@@ -28,7 +28,7 @@

import unittest

-import builders

+from builders import Builders

class BuildersTest(unittest.TestCase):

@@ -39,5 +39,6 @@ class BuildersTest(unittest.TestCase):

'Mac 10.6 (dbg)(1)': 'Mac_10_6__dbg__1_',

'(.) ': '____',

}

+ builders = Builders()

for name, expected in tests.items():

self.assertEqual(expected, builders.builder_path_from_name(name))