third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py - Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py

index 2e9a55d30935bec37fcc049263a295f956f31922..a157b4cfc6c3ab7f6e344d221589638ce6554e9a 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py

@@ -32,7 +32,7 @@ import optparse

from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand

from webkitpy.layout_tests.layout_package.bot_test_expectations import BotTestExpectationsFactory

from webkitpy.layout_tests.models.test_expectations import TestExpectationParser, TestExpectationsModel, TestExpectations

-from webkitpy.layout_tests.port import builders

+from webkitpy.layout_tests.port.builders import Builders

qyearsley 2016/05/02 21:56:36 This import may be unnecessary now. I don't see wh

bokan 2016/05/04 11:58:47 Done.

from webkitpy.common.net import sheriff_calendar

@@ -107,8 +107,8 @@ Flakiness dashboard: %s

return final_model._test_to_expectation_line.values()

def execute(self, options, args, tool):

- factory = self.expectations_factory()

- lines = self._collect_expectation_lines(builders.all_builder_names(), factory)

+ factory = self.expectations_factory(tool.builders)

+ lines = self._collect_expectation_lines(tool.builders.all_builder_names(), factory)

lines.sort(key=lambda line: line.path)

port = tool.port_factory.get()