Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py

Issue 1939843002: Replace webkitpy standalone builders functions with instantiable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved builders out of port, updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2011 Google Inc. All rights reserved. 1 # Copyright (c) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 14 matching lines...) Expand all
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import logging 29 import logging
30 import os 30 import os
31 import optparse 31 import optparse
32 from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand 32 from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
33 from webkitpy.layout_tests.layout_package.bot_test_expectations import BotTestEx pectationsFactory 33 from webkitpy.layout_tests.layout_package.bot_test_expectations import BotTestEx pectationsFactory
34 from webkitpy.layout_tests.models.test_expectations import TestExpectationParser , TestExpectationsModel, TestExpectations 34 from webkitpy.layout_tests.models.test_expectations import TestExpectationParser , TestExpectationsModel, TestExpectations
35 from webkitpy.layout_tests.port import builders
36 from webkitpy.common.net import sheriff_calendar 35 from webkitpy.common.net import sheriff_calendar
37 36
38 37
39 _log = logging.getLogger(__name__) 38 _log = logging.getLogger(__name__)
40 39
41 40
42 class FlakyTests(AbstractDeclarativeCommand): 41 class FlakyTests(AbstractDeclarativeCommand):
43 name = "print-flaky-tests" 42 name = "print-flaky-tests"
44 help_text = "Print out flaky lines from the flakiness dashboard" 43 help_text = "Print out flaky lines from the flakiness dashboard"
45 show_in_main_help = True 44 show_in_main_help = True
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 99
101 final_model = None 100 final_model = None
102 for model in models: 101 for model in models:
103 if final_model: 102 if final_model:
104 final_model.merge_model(model) 103 final_model.merge_model(model)
105 else: 104 else:
106 final_model = model 105 final_model = model
107 return final_model._test_to_expectation_line.values() 106 return final_model._test_to_expectation_line.values()
108 107
109 def execute(self, options, args, tool): 108 def execute(self, options, args, tool):
110 factory = self.expectations_factory() 109 factory = self.expectations_factory(tool.builders)
111 lines = self._collect_expectation_lines(builders.all_builder_names(), fa ctory) 110 lines = self._collect_expectation_lines(tool.builders.all_builder_names( ), factory)
112 lines.sort(key=lambda line: line.path) 111 lines.sort(key=lambda line: line.path)
113 112
114 port = tool.port_factory.get() 113 port = tool.port_factory.get()
115 # Skip any tests which are mentioned in the dashboard but not in our che ckout: 114 # Skip any tests which are mentioned in the dashboard but not in our che ckout:
116 fs = tool.filesystem 115 fs = tool.filesystem
117 lines = filter(lambda line: fs.exists(fs.join(port.layout_tests_dir(), l ine.path)), lines) 116 lines = filter(lambda line: fs.exists(fs.join(port.layout_tests_dir(), l ine.path)), lines)
118 117
119 test_names = [line.name for line in lines] 118 test_names = [line.name for line in lines]
120 flakiness_dashbord_url = self.FLAKINESS_DASHBOARD_URL % ','.join(test_na mes) 119 flakiness_dashbord_url = self.FLAKINESS_DASHBOARD_URL % ','.join(test_na mes)
121 expectations_string = TestExpectations.list_to_string(lines) 120 expectations_string = TestExpectations.list_to_string(lines)
122 121
123 # pylint: disable=E1601 122 # pylint: disable=E1601
124 print self.OUTPUT % (self.HEADER, expectations_string, flakiness_dashbor d_url) 123 print self.OUTPUT % (self.HEADER, expectations_string, flakiness_dashbor d_url)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698