Replace webkitpy standalone builders functions with instantiable class.

third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

 # Copyright (c) 2010 Google Inc. All rights reserved.
 # Copyright (c) 2009 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import logging
 import os
 import sys
 
 from webkitpy.common.checkout.scm.detection import SCMDetector
 from webkitpy.common.memoized import memoized
 from webkitpy.common.net import buildbot, web
 from webkitpy.common.system.systemhost import SystemHost
+from webkitpy.layout_tests.port.builders import Builders
 from webkitpy.layout_tests.port.factory import PortFactory
 
 
 _log = logging.getLogger(__name__)
 
 
 class Host(SystemHost):
 
     def __init__(self):
         SystemHost.__init__(self)
         self.web = web.Web()
 
         self._scm = None
 
         # Everything below this line is WebKit-specific and belongs on a higher-level object.
         self.buildbot = buildbot.BuildBot()
 
         # FIXME: Unfortunately Port objects are currently the central-dispatch objects of the NRWT world.
         # In order to instantiate a port correctly, we have to pass it at least an executive, user, scm, and filesystem
         # so for now we just pass along the whole Host object.
         # FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency).
         self.port_factory = PortFactory(self)
 
         self._engage_awesome_locale_hacks()
 
+        self.builders = Builders()

[qyearsley, 2016/05/02 21:56:36]

In general, does it make sense for builders to be a member attribute of Host?
(Does Host represent the specific machine that's running a command or tests?)

[bokan, 2016/05/04 11:58:47]

Host seems to be a general global state object. I'm not sure where else this
could be put so it would be accessible where needed. Port is the other obvious
candidate but we need the list of builders in order to construct a Port so that
can't be it. Dirk might know more if this is appropriate.

[Dirk Pranke, 2016/05/04 22:42:36]

Host is appropriate enough; we don't need to over-think this.

+
     # We call this from the Host constructor, as it's one of the
     # earliest calls made for all webkitpy-based programs.
     def _engage_awesome_locale_hacks(self):
         # To make life easier on our non-english users, we override
         # the locale environment variables inside webkitpy.
         # If we don't do this, programs like SVN will output localized
         # messages and svn.py will fail to parse them.
         # FIXME: We should do these overrides *only* for the subprocesses we know need them!
         # This hack only works in unix environments.
         os.environ['LANGUAGE'] = 'en'
@@ skipping 35 matching lines @@
 
     def scm(self):
         return self._scm
 
     def scm_for_path(self, path):
         # FIXME: make scm() be a wrapper around this, and clean up the way
         # callers call initialize_scm() (to remove patch_directories) and scm().
         if sys.platform == "win32":
             self._engage_awesome_windows_hacks()
         return SCMDetector(self.filesystem, self.executive).detect_scm_system(path)