Issue 1939833003: Sanitize inheritance in callers of utils.expose

Issue 1939833003: Sanitize inheritance in callers of utils.expose (Closed)

Created:
4 years, 7 months ago by robwu

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Sanitize inheritance in callers of utils.expose - Let all private classes inherit from the null prototype. - Use safe built-ins. - Minor drive-by fixes (code style). BUG=603748, 591164 Review-Url: https://codereview.chromium.org/1915753002 Cr-Commit-Position: refs/heads/master@{#390510} (cherry picked from commit 931719c51866a7c2e272114517cc52aa6581adff) Committed: https://chromium.googlesource.com/chromium/src/+/c29bc7edad5f1e80cad11d50a1cd880456cb54cb

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+218 lines, -158 lines)			Patch
M	chrome/renderer/resources/extensions/automation/automation_event.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/resources/extensions/automation/automation_node.js	View	16 chunks	+68 lines, -58 lines	0 comments	Download
M	chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/renderer/resources/extensions/enterprise_platform_keys/token.js	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/resources/extensions/platform_keys/key.js	View	3 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/resources/extensions/web_view/chrome_web_view.js	View	5 chunks	+18 lines, -16 lines	0 comments	Download
M	extensions/renderer/resources/event.js	View	13 chunks	+39 lines, -34 lines	0 comments	Download
M	extensions/renderer/resources/messaging.js	View	5 chunks	+38 lines, -22 lines	0 comments	Download
M	extensions/renderer/resources/utils.js	View	3 chunks	+19 lines, -2 lines	0 comments	Download
M	extensions/renderer/resources/web_request_internal_custom_bindings.js	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	extensions/renderer/safe_builtins.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

robwu

4 years, 7 months ago (2016-05-02 20:27:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c29bc7edad5f1e80cad11d50a1cd880456cb54cb.