Chromium Code Reviews Chromium Code Reviews
Issue 1939823002:
Update to libjpeg_turbo 1.4.90 (Closed)
Base URL: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master| OLD | NEW |
|---|---|
| 1 Name: libjpeg-turbo | 1 Name: libjpeg-turbo |
| 2 URL: http://sourceforge.net/projects/libjpeg-turbo/ | 2 URL: https://github.com/libjpeg-turbo/libjpeg-turbo/ |
| 3 Version: 1.3.1 | 3 Version: 1.4.90 |
| 4 License: Custom license | 4 License: Custom license |
| 5 License File: LICENSE.txt | 5 License File: LICENSE.md |
| 6 Security Critical: yes | 6 Security Critical: yes |
| 7 License Android Compatible: yes | 7 License Android Compatible: yes |
| 8 | 8 |
| 9 Description: | 9 Description: |
| 10 This consists of the components: | 10 This consists of the components: |
| 11 * A partial copy of libjpeg-turbo 1.3.1 (r1219); | 11 * libjpeg-turbo 1.4.90 |
| 12 * Revision r1188 cherry-picked from upstream trunk into config.h to fix | 12 * Cherry picked clang fix for Arm32 assembly from upstream master: |
| 13 compiler warning on newer versions of gcc; | 13 https://github.com/libjpeg-turbo/libjpeg-turbo/commit/5e576386b57663bbe9d934ed f7c276eb0150cd59 |
| 14 * Revision r1220 cherry-picked from upstream trunk into jchuff.c to use | 14 https://github.com/libjpeg-turbo/libjpeg-turbo/commit/2e480fa2a3285d9ff83a780a b3417badeb3f2d37 |
| 15 clz/bsr instructions on ARM for bit counting rather than the lookup table | |
| 16 (reduces memory footprint and can improve performance in some cases); | |
| 17 * Revisions r1108, r1109, r1333, r1375, r1386, r1389 and r1390 cherry-picked | |
| 18 from upstream trunk for Arm64 NEON SIMD support; | |
| 19 * Revisions r1582, r1583, r1586, r1587, r1591, and | |
| 20 commit 91eceba0a132a3fc70388a82c75616e67725a93a (code moved to GitHub) | |
| 21 cherry-picked from upstream trunk for partial decoding optimization; | |
| 22 http://crbug.com/515694 | |
| 23 * Revisions r1295, r1385, r1398, and r1402 (r1386 is also required but has | |
| 24 already been cherry-picked) cherry-picked from upstream trunk to enable | |
| 25 decoding to 565 as a memory optimization; | |
| 26 http://crbug.com/516761 | |
| 27 * Commit 8b2c04f774d18e05e321ee67a9a38b4d7e84f168 from upstream to zero-extend | |
| 28 32-bit arguments before using them as 64-bit values: http://crbug.com/532214 | |
| 29 * A build file (libjpeg.gyp), and; | |
| 30 * Patched header files used by Chromium. | |
| 31 | 15 |
| 32 More details on cherry-picked revisions and commits can be found at: | 16 * This file (README.chromium) |
| 33 https://sourceforge.net/p/libjpeg-turbo/code/commit_browser | 17 * A build file (libjpeg.gyp) |
| 34 https://github.com/libjpeg-turbo/libjpeg-turbo/commits/master | 18 * Patched header files used by Chromium |
| 19 * Deleted unused directories: cmakescripts, doc, java, md5, release, sharedlib, | |
| 20 * testimages, and win | |
| 35 | 21 |
| 36 This libjpeg-turbo can replace our libjpeg-6b without any modifications in the | 22 This libjpeg-turbo can replace our libjpeg-6b without any modifications in the |
| 37 Chromium code. | 23 Chromium code. |
| 38 | 24 |
| 39 Same as our copy of libjpeg-6b, this libjpeg-turbo also added a new file | 25 Same as our copy of libjpeg-6b, this libjpeg-turbo also added a new file |
| 40 jpeglibmangler.h and included it from jpeglib.h that changes the names of all | 26 jpeglibmangler.h and included it from jpeglib.h that changes the names of all |
| 41 externally visible functions to chromium_* so that we can avoid conflicts that | 27 externally visible functions to chromium_* so that we can avoid conflicts that |
| 42 arise when system libraries attempt to use our libjpeg. Also, we applied the | 28 arise when system libraries attempt to use our libjpeg. Also, we applied the |
| 43 following changes which are not merged to upstream: | 29 following changes which are not merged to upstream: |
| 44 | 30 |
| 45 * Added the 'private_extern' flags on Mac (or the 'hidden' flags on Linux) to | |
| 46 all the global symbols in '.asm' files to prevent making them external ones. | |
| 47 * Supported motion-JPEG frames that do not have DHT markers. | |
| 48 * Fix libjpeg_turbo svn r64 libjpeg6b compat issue: make the fast path Huffman | |
| 49 decoder fallback to slow decoding if the Huffman decoding bit sentinel > 16, | |
| 50 this to match the exact behavior of jpeg_huff_decode(). | |
| 51 http://crbug.com/398235 | |
| 52 * Fixed an issue with the ARM NEON build. | |
| 53 http://crbug.com/451035 | |
| 54 | |
|
Noel Gordon
2016/05/04 13:18:07
Looks like we've removed this group of 4 fixes. W
msarett
2016/05/04 15:24:12
(1) private_extern flags
I intend to add this back
Noel Gordon
2016/05/04 15:53:35
Sounds like a plan. Notes like these should be ad
| |
| 55 Refer to working-with-nested-repos [1] for details of how to setup your git | 31 Refer to working-with-nested-repos [1] for details of how to setup your git |
| 56 svn client to update the code (for making local changes, cherry picking from | 32 svn client to update the code (for making local changes, cherry picking from |
| 57 upstream, etc). | 33 upstream, etc). |
| 58 | 34 |
| 59 [1] https://www.chromium.org/developers/how-tos/get-the-code/working-with-nested -repos | 35 [1] https://www.chromium.org/developers/how-tos/get-the-code/working-with-nested -repos |
| OLD | NEW |
