Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1939813002: Update word-spacing TODO (Closed)

Created:
4 years, 7 months ago by rwlbuis
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh, rune
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update word-spacing TODO According to [1] we should allow unitless quirks for word-spacing and letter-spacing. [1] https://quirks.spec.whatwg.org/#the-unitless-length-quirk Committed: https://crrev.com/6159adb1f883d7cccd2f1eb797cd825a2f460a39 Cr-Commit-Position: refs/heads/master@{#391411}

Patch Set 1 #

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
rwlbuis
PTAL, seems pretty clear to me given the spec.
4 years, 7 months ago (2016-05-03 18:16:25 UTC) #4
Timothy Loh
On 2016/05/03 18:16:25, rwlbuis wrote: > PTAL, seems pretty clear to me given the spec. ...
4 years, 7 months ago (2016-05-03 23:37:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939813002/20001
4 years, 7 months ago (2016-05-03 23:48:34 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 01:20:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939813002/20001
4 years, 7 months ago (2016-05-04 01:47:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 02:12:08 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 02:13:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6159adb1f883d7cccd2f1eb797cd825a2f460a39
Cr-Commit-Position: refs/heads/master@{#391411}

Powered by Google App Engine
This is Rietveld 408576698