Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1939803002: DevTools: mute the node highlight & hide devtools while taking screenshots. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: mute the node highlight & hide devtools while taking screenshots. BUG=600701, 604622 Committed: https://crrev.com/2c35ac648003709b4dcc67e3c38a3ffcc6f3632e Cr-Commit-Position: refs/heads/master@{#391154}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 3 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pfeldman
4 years, 7 months ago (2016-05-02 15:24:43 UTC) #2
pfeldman
4 years, 7 months ago (2016-05-02 23:33:33 UTC) #5
caseq
lgtm
4 years, 7 months ago (2016-05-02 23:45:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939803002/20001
4 years, 7 months ago (2016-05-03 00:08:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 01:56:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:57:52 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2c35ac648003709b4dcc67e3c38a3ffcc6f3632e
Cr-Commit-Position: refs/heads/master@{#391154}

Powered by Google App Engine
This is Rietveld 408576698