Remove all uses of skia::RefPtr and stale includes

Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
TBR=miguelg@chromium.org
BUG=skia:5077, 604716
Committed: https://crrev.com/709a7536e917ff3c294810cd2c76008d43630ccd
Cr-Commit-Position: refs/heads/master@{#391206}

[tomhudson, 2016-05-02 15:10:50]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 15:11:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939783002/20001

[commit-bot: I haz the power, 2016-05-02 15:56:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 15:56:03]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-05-02 16:07:17]

Florin: Skia review, please.
Torne: please review android_webview/ and content/public/browser/android/.
changwan@: please review chrome/browser/android/compositor/.

[f(malita), 2016-05-02 16:51:41]

Non-owner LGTM, w/ a couple of nits.

https://codereview.chromium.org/1939783002/diff/20001/android_webview/browser...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/1939783002/diff/20001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:320: return
sk_sp<SkPicture>(emptyRecorder.finishRecordingAsPicture());
finishRecordingAsPicture() returns an sk_sp<SkPicture> - no need to repackage.

https://codereview.chromium.org/1939783002/diff/20001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:335: return
sk_sp<SkPicture>(recorder.finishRecordingAsPicture());
Ditto.

[tomhudson, 2016-05-02 19:09:16]

Description was changed from

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
BUG=skia:5077
==========

to

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org,
miguelg@chromium.org
BUG=skia:5077,604716
==========

[tomhudson, 2016-05-02 19:09:16]

tomhudson@google.com changed reviewers:
+ miguelg@chromium.org

[tomhudson, 2016-05-02 19:10:31]

On 2016/05/02 16:51:41, f(malita) wrote:
> a couple of nits.

Done.

+Miguel: please review chrome/browser/android/, since I removed one line from
one file Torne isn't OWNER on.

[Changwan Ryu, 2016-05-03 02:26:45]

chrome/browser/android/compositor/ lgtm. Thanks for fixing includes as well.

[Torne, 2016-05-03 11:17:12]

Miguel is OOO all this week, you might want to find a different owner.

android_webview LGTM

[tomhudson, 2016-05-03 11:30:12]

Description was changed from

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org,
miguelg@chromium.org
BUG=skia:5077,604716
==========

to

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
TBR=miguelg@chromium.org
BUG=skia:5077,604716
==========

[tomhudson, 2016-05-03 11:30:31]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-05-03 11:30:31]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1939783002/#ps40001
(title: "Florin's nits")

[commit-bot: I haz the power, 2016-05-03 11:30:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939783002/40001

[commit-bot: I haz the power, 2016-05-03 12:16:24]

Description was changed from

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
TBR=miguelg@chromium.org
BUG=skia:5077,604716
==========

to

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
TBR=miguelg@chromium.org
BUG=skia:5077,604716
==========

[commit-bot: I haz the power, 2016-05-03 12:16:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 12:17:51]

Description was changed from

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
TBR=miguelg@chromium.org
BUG=skia:5077,604716
==========

to

==========
Remove all uses of skia::RefPtr and stale includes

This CL is the Android-specific section of the change.

Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.

We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.

R=fmalita@chromium.org,torne@chromium.org,changwan@chromium.org
TBR=miguelg@chromium.org
BUG=skia:5077,604716

Committed: https://crrev.com/709a7536e917ff3c294810cd2c76008d43630ccd
Cr-Commit-Position: refs/heads/master@{#391206}
==========

[commit-bot: I haz the power, 2016-05-03 12:17:52]

Patchset 3 (id:??) landed as
https://crrev.com/709a7536e917ff3c294810cd2c76008d43630ccd
Cr-Commit-Position: refs/heads/master@{#391206}