src/s390/macro-assembler-s390.cc - Issue 1939763003: S390X: Prevent upper 32bit corruption in 32bit ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/s390/macro-assembler-s390.cc

Issue 1939763003: S390X: Prevent upper 32bit corruption in 32bit ops (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/s390/macro-assembler-s390.cc

diff --git a/src/s390/macro-assembler-s390.cc b/src/s390/macro-assembler-s390.cc

index ea1079e4d658244bd75002fedb368afde0500ea2..f4382d36c7762120e7bdd01e98c8ba4ca9a0259a 100644

--- a/src/s390/macro-assembler-s390.cc

+++ b/src/s390/macro-assembler-s390.cc

@@ -1925,7 +1925,7 @@ void MacroAssembler::AllocateTwoByteString(Register result, Register length,

// observing object alignment.

DCHECK((SeqTwoByteString::kHeaderSize & kObjectAlignmentMask) == 0);

- ShiftLeft(scratch1, length, Operand(1)); // Length in bytes, not chars.

+ ShiftLeftP(scratch1, length, Operand(1)); // Length in bytes, not chars.

AddP(scratch1, Operand(kObjectAlignmentMask + SeqTwoByteString::kHeaderSize));

AndP(scratch1, Operand(~kObjectAlignmentMask));