Completely detach failed script loader before dispatching error event.

Completely detach failed script loader before dispatching error event.

In case of failure, a ScriptLoader needs to be detached from its ScriptRunner
and associated Resource (if any) at the same time, and before dispatching
the corresponding error event. If the error event handler triggers cancellation
of the Resource, the ScriptLoader should not be notified of that again --
it isn't interested nor prepared. A speculative fix.

R=
BUG=602516
Committed: https://crrev.com/78eefc78b6be044e73f95527b1ce9a58c6e0f585
Cr-Commit-Position: refs/heads/master@{#390955}

[sof, 2016-05-02 14:26:37]

Description was changed from

==========
Experiment: catch out duplicate pending async script additions.

R=
BUG=
==========

to

==========
Completely detach failed script loader before dispatching error event.

In case of failure, a ScriptLoader needs to be detached from its ScriptRunner
and associated Resource (if any) at the same time, and before dispatching
the corresponding error event. If the error event handler triggers cancellation
of the Resource, the ScriptLoader should not be notified of that again --
it isn't interested nor prepared. A speculative fix.

R=
BUG=602516
==========

[sof, 2016-05-02 14:42:24]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, japhet@chromium.org

[sof, 2016-05-02 14:42:24]

please take a look.

[haraken, 2016-05-02 15:43:15]

LGTM

[sof, 2016-05-02 15:47:27]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-02 15:47:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939743002/40001

[commit-bot: I haz the power, 2016-05-02 15:59:13]

Description was changed from

==========
Completely detach failed script loader before dispatching error event.

In case of failure, a ScriptLoader needs to be detached from its ScriptRunner
and associated Resource (if any) at the same time, and before dispatching
the corresponding error event. If the error event handler triggers cancellation
of the Resource, the ScriptLoader should not be notified of that again --
it isn't interested nor prepared. A speculative fix.

R=
BUG=602516
==========

to

==========
Completely detach failed script loader before dispatching error event.

In case of failure, a ScriptLoader needs to be detached from its ScriptRunner
and associated Resource (if any) at the same time, and before dispatching
the corresponding error event. If the error event handler triggers cancellation
of the Resource, the ScriptLoader should not be notified of that again --
it isn't interested nor prepared. A speculative fix.

R=
BUG=602516
==========

[commit-bot: I haz the power, 2016-05-02 15:59:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-02 16:00:38]

Description was changed from

==========
Completely detach failed script loader before dispatching error event.

In case of failure, a ScriptLoader needs to be detached from its ScriptRunner
and associated Resource (if any) at the same time, and before dispatching
the corresponding error event. If the error event handler triggers cancellation
of the Resource, the ScriptLoader should not be notified of that again --
it isn't interested nor prepared. A speculative fix.

R=
BUG=602516
==========

to

==========
Completely detach failed script loader before dispatching error event.

In case of failure, a ScriptLoader needs to be detached from its ScriptRunner
and associated Resource (if any) at the same time, and before dispatching
the corresponding error event. If the error event handler triggers cancellation
of the Resource, the ScriptLoader should not be notified of that again --
it isn't interested nor prepared. A speculative fix.

R=
BUG=602516

Committed: https://crrev.com/78eefc78b6be044e73f95527b1ce9a58c6e0f585
Cr-Commit-Position: refs/heads/master@{#390955}
==========

[commit-bot: I haz the power, 2016-05-02 16:00:38]

Patchset 3 (id:??) landed as
https://crrev.com/78eefc78b6be044e73f95527b1ce9a58c6e0f585
Cr-Commit-Position: refs/heads/master@{#390955}