Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

Issue 1939713003: Dispatch events in isolated worlds, even if script execution is forbidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/permissionclient/script-permissions-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
index 95c22fbd43786fd59cac35f84624bf02dec0ad96..017860884af8edf851e764f06149694d09abcff1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp
@@ -86,7 +86,8 @@ v8::Local<v8::Value> V8EventListener::callListenerFunction(ScriptState* scriptSt
if (!frame)
return v8::Local<v8::Value>();
- if (!frame->script().canExecuteScripts(AboutToExecuteScript))
+ // TODO(jochen): Consider moving this check into canExecuteScripts. http://crbug.com/608641
+ if (scriptState->world().isMainWorld() && !frame->script().canExecuteScripts(AboutToExecuteScript))
return v8::Local<v8::Value>();
v8::Local<v8::Value> parameters[1] = { jsEvent };
« no previous file with comments | « third_party/WebKit/LayoutTests/permissionclient/script-permissions-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698