Don't crash on deserialized type inference.

Don't crash on deserialized type inference.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f79ff62b2ee08ca518abe49d880847a5f3f334cd

[Johnni Winther, 2016-05-02 08:36:14]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-02 16:21:43]

lgtm

https://codereview.chromium.org/1939703002/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart (right):

https://codereview.chromium.org/1939703002/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:347: /// with
[TreeElements].
let's update the comment to say that this deserializes the resolved AST of an
element and it's nested elements (maybe clarify also that the outer element is a
function/procedure, and that nested elements are closures)?

https://codereview.chromium.org/1939703002/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:645:
resolvedAstMap[function] = new ParsedResolvedAst(
do we need to assert that the key doesn't exist already? (seems like an
invariant in how we are using this from serialization_helper.)

Alternatively, instead of passing in the output-map, we could return a fresh map
each time you call this function. It's more wasted memory, but that might be
fine, then here we don't need to care about any invariants about the map.

[Johnni Winther, 2016-05-03 09:29:29]

Description was changed from

==========
Don't crash on deserialized type inference.
==========

to

==========
Don't crash on deserialized type inference.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f79ff62b2ee08ca518abe49d880847a5f3f334cd
==========

[Johnni Winther, 2016-05-03 09:29:31]

Committed patchset #3 (id:40001) manually as
f79ff62b2ee08ca518abe49d880847a5f3f334cd (presubmit successful).

[Johnni Winther, 2016-05-04 09:56:25]

https://codereview.chromium.org/1939703002/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart (right):

https://codereview.chromium.org/1939703002/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:347: /// with
[TreeElements].
On 2016/05/02 16:21:43, Siggi Cherem (dart-lang) wrote:
> let's update the comment to say that this deserializes the resolved AST of an
> element and it's nested elements (maybe clarify also that the outer element is
a
> function/procedure, and that nested elements are closures)?

Done.

https://codereview.chromium.org/1939703002/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:645:
resolvedAstMap[function] = new ParsedResolvedAst(
On 2016/05/02 16:21:43, Siggi Cherem (dart-lang) wrote:
> do we need to assert that the key doesn't exist already? (seems like an
> invariant in how we are using this from serialization_helper.)
> 
> Alternatively, instead of passing in the output-map, we could return a fresh
map
> each time you call this function. It's more wasted memory, but that might be
> fine, then here we don't need to care about any invariants about the map.

Invariant test added!