Issue 19397002: Provide named links to code objects in heap snapshot.

Issue 19397002: Provide named links to code objects in heap snapshot. (Closed)

Created:
7 years, 5 months ago by alph

Modified:
7 years, 5 months ago

Reviewers:
yurys, Toon Verwaest, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Provide named links to code objects in heap snapshot. R=loislo@chromium.org, verwaest@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15722

Patch Set 3 : Removed magic number 3. #

Patch Set 4 : Missed the main part. #

Patch Set 5 : Add missing edge type to GetName API. Wondering how it worked before??? #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -41 lines)			Patch
M	src/api.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 2 3	41 chunks	+59 lines, -41 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yurys

https://codereview.chromium.org/19397002/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/19397002/diff/1/src/heap-snapshot-generator.cc#newcode898 src/heap-snapshot-generator.cc:898: Code* code = Code::cast(Code::GetObjectFromEntryAddress(entry_address)); Can we have a test ...

7 years, 5 months ago (2013-07-16 18:26:10 UTC) #3

alph

ptal https://codereview.chromium.org/19397002/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/19397002/diff/1/src/heap-snapshot-generator.cc#newcode898 src/heap-snapshot-generator.cc:898: Code* code = Code::cast(Code::GetObjectFromEntryAddress(entry_address)); On 2013/07/16 18:26:10, Yury ...

7 years, 5 months ago (2013-07-17 10:08:22 UTC) #4

yurys

lgtm https://codereview.chromium.org/19397002/diff/6001/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/19397002/diff/6001/test/cctest/test-heap-profiler.cc#newcode1975 test/cctest/test-heap-profiler.cc:1975: CHECK(ValidateSnapshot(snapshot, 3)); Could you make 3 a default ...

7 years, 5 months ago (2013-07-17 10:24:01 UTC) #5

alph

7 years, 5 months ago (2013-07-17 13:13:00 UTC) #8

Message was sent while issue was closed.

Committed patchset #5 manually as r15722 (presubmit successful).

Expand Messages | Collapse Messages