Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1939693002: Get the correct page size for linearized PDFs. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
spelchat
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get the correct page size for linearized PDFs. BUG=604146 Committed: https://crrev.com/21699f821ea44f1d34adc94cc0f8abbfb22c1525 Cr-Commit-Position: refs/heads/master@{#391011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-05-02 18:20:48 UTC) #2
spelchat
On 2016/05/02 18:20:48, Lei Zhang wrote: LGTM
4 years, 7 months ago (2016-05-02 18:35:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939693002/1
4 years, 7 months ago (2016-05-02 18:43:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 18:48:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/21699f821ea44f1d34adc94cc0f8abbfb22c1525 Cr-Commit-Position: refs/heads/master@{#391011}
4 years, 7 months ago (2016-05-02 18:51:11 UTC) #8
Wei Li
4 years, 7 months ago (2016-05-03 19:21:13 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1942253003/ by weili@chromium.org.

The reason for reverting is: Speculative revert due to high crash volume in 
Chromium..

Powered by Google App Engine
This is Rietveld 408576698