Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: net/cookies/cookie_monster.h

Issue 1939623002: Strict Secure Cookies re-implemented to be priority aware (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix Windows build Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index b31ac6d4b6fab663ea60ddd0b2b17ba3a651c3b1..a88f166b43d90971f436a56d22261e9cb6b3f0e5 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -549,6 +549,8 @@ class NET_EXPORT CookieMonster : public CookieStore {
// Helper for GarbageCollect(). Deletes up to |purge_goal| cookies with a
// priority less than or equal to |priority| from |cookies|, while ensuring
// that at least the |to_protect| most-recent cookies are retained.
+ // |protected_secure_cookies| specifies whether or not secure cookies should
+ // be protected from deletion.
//
// |cookies| must be sorted from least-recent to most-recent.
//
@@ -556,7 +558,8 @@ class NET_EXPORT CookieMonster : public CookieStore {
size_t PurgeLeastRecentMatches(CookieItVector* cookies,
CookiePriority priority,
size_t to_protect,
- size_t purge_goal);
+ size_t purge_goal,
+ bool protect_secure_cookies);
// Helper for GarbageCollect(); can be called directly as well. Deletes all
// expired cookies in |itpair|. If |cookie_its| is non-NULL, all the
@@ -567,14 +570,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
const CookieMapItPair& itpair,
CookieItVector* cookie_its);
- // Helper for GarbageCollect(). Deletes all cookies not marked Secure in
- // |valid_cookies_its|. If |cookie_its| is non-NULL, all the Secure cookies
- // from |itpair| are appended to |cookie_its|.
- //
- // Returns the numeber of cookies deleted.
- size_t GarbageCollectNonSecure(const CookieItVector& valid_cookies,
- CookieItVector* cookie_its);
-
// Helper for GarbageCollect(). Deletes all cookies in the range specified by
// [|it_begin|, |it_end|). Returns the number of cookies deleted.
size_t GarbageCollectDeleteRange(const base::Time& current,
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698