Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1939603002: gn: Stop printing all help when the command is unknown (Closed)

Created:
4 years, 7 months ago by watk
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Stop printing all help when the command is unknown When a command is unrecognized (usually due to a typo), gn previously printed all the top level help, which scrolled the error off the screen. Now it just prints the list of known commands. BUG= Committed: https://crrev.com/f2347fca65aa949fb935c500142a5110f99e453c Cr-Commit-Position: refs/heads/master@{#390999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/gn/gn_main.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
watk
Hi Brett, I found this to be a minor UX problem. It seems like printing ...
4 years, 7 months ago (2016-04-30 02:37:27 UTC) #3
brettw
lgtm
4 years, 7 months ago (2016-05-02 16:38:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939603002/1
4 years, 7 months ago (2016-05-02 17:42:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 18:29:30 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:30:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2347fca65aa949fb935c500142a5110f99e453c
Cr-Commit-Position: refs/heads/master@{#390999}

Powered by Google App Engine
This is Rietveld 408576698