MD Settings: make the background color of the collapsed nav drawer white

MD Settings: make the background color of the collapsed nav drawer white

Also makes the drawer hotdogs button stop shrinking.

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fc341c7887e4b2d2a79317ab22c8b5f5494a4a0c
Cr-Commit-Position: refs/heads/master@{#391448}

[Dan Beam, 2016-05-02 23:45:09]

Description was changed from

==========
MD Settings: make the background color of the collapsed nav drawer white

R=dschuyler@chromium.org
BUG=608519
==========

to

==========
MD Settings: make the background color of the collapsed nav drawer white

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-03 00:36:12]

LGTM, plus a suggestion.

https://codereview.chromium.org/1939373002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1939373002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:40:
background-color: white;
optional: maybe 
background-color: var(--settings-drawer-color);
where --settings-drawer-color is white? 
It amounts to the same thing, but it would help
keep the color definitions in the same place.
(That place being settings_shared_css.html right
now, but may move later).

[Dan Beam, 2016-05-03 00:37:10]

https://codereview.chromium.org/1939373002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1939373002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:40:
background-color: white;
On 2016/05/03 00:36:12, dschuyler wrote:
> optional: maybe 
> background-color: var(--settings-drawer-color);
> where --settings-drawer-color is white? 
> It amounts to the same thing, but it would help
> keep the color definitions in the same place.
> (That place being settings_shared_css.html right
> now, but may move later).

we shouldn't be adding variables if they're only used once.

i'll add a variable if this is needed anywhere else in settings or in other UIs
(i.e. history), which is likely.

[Dan Beam, 2016-05-03 02:22:58]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2016-05-03 02:23:07]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2016-05-03 02:23:12]

Patchset #2 (id:40001) has been deleted

[Dan Beam, 2016-05-03 02:40:18]

sooooo, had to make a lot of changes

please take another look

[dschuyler, 2016-05-03 22:57:56]

https://codereview.chromium.org/1939373002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/1939373002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.js:31: 'iron-select':
'onIronSelect_',
I may be misunderstanding, but it looks like
iron-select may be fired from a variety of 
elements (unlike the paper-responsive-change
which looks like it's only for the drawer).

Is it reasonable or useful to scope (qualify)
this more? Though maybe it's not a big deal
to remove .narrowing on other things. WDYT

[Dan Beam, 2016-05-03 23:28:37]

https://codereview.chromium.org/1939373002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/1939373002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.js:31: 'iron-select':
'onIronSelect_',
On 2016/05/03 22:57:56, dschuyler wrote:
> I may be misunderstanding, but it looks like
> iron-select may be fired from a variety of 
> elements (unlike the paper-responsive-change
> which looks like it's only for the drawer).
> 
> Is it reasonable or useful to scope (qualify)
> this more? Though maybe it's not a big deal
> to remove .narrowing on other things. WDYT

Done.

[Dan Beam, 2016-05-03 23:31:26]

Description was changed from

==========
MD Settings: make the background color of the collapsed nav drawer white

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: make the background color of the collapsed nav drawer white

Also makes the drawer hotdogs button stop shrinking.

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-03 23:33:29]

lgtm

[Dan Beam, 2016-05-03 23:35:22]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-05-03 23:36:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939373002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939373002/80001

[commit-bot: I haz the power, 2016-05-04 00:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:23:46]

Failed to apply the patch.

[Dan Beam, 2016-05-04 05:00:44]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-05-04 05:00:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1939373002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1939373002/80001

[commit-bot: I haz the power, 2016-05-04 05:04:26]

Description was changed from

==========
MD Settings: make the background color of the collapsed nav drawer white

Also makes the drawer hotdogs button stop shrinking.

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: make the background color of the collapsed nav drawer white

Also makes the drawer hotdogs button stop shrinking.

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-04 05:04:27]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-05-04 05:05:57]

Description was changed from

==========
MD Settings: make the background color of the collapsed nav drawer white

Also makes the drawer hotdogs button stop shrinking.

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: make the background color of the collapsed nav drawer white

Also makes the drawer hotdogs button stop shrinking.

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fc341c7887e4b2d2a79317ab22c8b5f5494a4a0c
Cr-Commit-Position: refs/heads/master@{#391448}
==========

[commit-bot: I haz the power, 2016-05-04 05:05:58]

Patchset 3 (id:??) landed as
https://crrev.com/fc341c7887e4b2d2a79317ab22c8b5f5494a4a0c
Cr-Commit-Position: refs/heads/master@{#391448}