Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1939363002: Remove unused FontRenderStyle from Windows build (Closed)

Created:
4 years, 7 months ago by tzik
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused FontRenderStyle from Windows build FontRenderStyle in FontPlatformData is not used on Windows, but used only on Linux and Android. The instance will be moved from FontPlatformData to SimpleFontData by a following CL, and this CL loosens the dependency to FontRenderStyle as a preparation. BUG=608650 Committed: https://crrev.com/27378dd740cd0a8bb476c4e1b816ce9740665ebe Cr-Commit-Position: refs/heads/master@{#391268}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -111 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/linux/WebFontRenderStyle.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontPlatformData.h View 1 2 3 4 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp View 1 2 3 7 chunks +4 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/platform/fonts/FontRenderStyle.h View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
A + third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939363002/1
4 years, 7 months ago (2016-05-02 23:34:51 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 02:31:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939363002/20001
4 years, 7 months ago (2016-05-03 07:53:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939363002/40001
4 years, 7 months ago (2016-05-03 08:11:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/64075)
4 years, 7 months ago (2016-05-03 08:36:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939363002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939363002/80001
4 years, 7 months ago (2016-05-03 08:59:21 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 12:43:37 UTC) #17
tzik
PTAL
4 years, 7 months ago (2016-05-03 16:46:28 UTC) #18
eae
LGTM Very nice, thanks for doing this type of cleanup work!
4 years, 7 months ago (2016-05-03 16:49:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939363002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939363002/80001
4 years, 7 months ago (2016-05-03 16:51:04 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-03 16:56:27 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 16:57:56 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/27378dd740cd0a8bb476c4e1b816ce9740665ebe
Cr-Commit-Position: refs/heads/master@{#391268}

Powered by Google App Engine
This is Rietveld 408576698