Write adjusted range back to module

google_breakpad/processor/minidump.h

 // Copyright (c) 2010 Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 364 matching lines @@
   }
   static uint32_t max_cv_bytes() { return max_cv_bytes_; }
 
   static void set_max_misc_bytes(uint32_t max_misc_bytes) {
     max_misc_bytes_ = max_misc_bytes;
   }
   static uint32_t max_misc_bytes() { return max_misc_bytes_; }
 
   const MDRawModule* module() const { return valid_ ? &module_ : NULL; }
 
+  void adjust_base_address_and_size(uint64_t base_address, uint64_t size);

[Mark Mentovai, 2016/05/03 04:07:07]

“Set” instead of “adjust”. “Adjust” makes it sound like the arguments might be
offsets. “Set” makes it clear that they’re not.

Since this is weird and we wouldn’t want willy-nilly setting, please also add a
brief comment explaining why it’s necessary.

[michaelbai, 2016/05/03 19:40:56]

Done.

+
   // CodeModule implementation
   virtual uint64_t base_address() const {
     return valid_ ? module_.base_of_image : static_cast<uint64_t>(-1);
   }
   virtual uint64_t size() const { return valid_ ? module_.size_of_image : 0; }
   virtual string code_file() const;
   virtual string code_identifier() const;
   virtual string debug_file() const;
   virtual string debug_identifier() const;
   virtual string version() const;
@@ skipping 726 matching lines @@
   // construction or after a failed Read(); true following a successful
   // Read().
   bool                      valid_;
 };
 
 
 }  // namespace google_breakpad
 
 
 #endif  // GOOGLE_BREAKPAD_PROCESSOR_MINIDUMP_H__