third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 1939303002: Enable accessible name of a control to include multiple <label> elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 1939303002: Enable accessible name of a control to include multiple <label> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index e266b884d4ff36cf101dce4b23c5396d7104df24..2234e713d83eacc99f6c50416590d630335b8611 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -74,7 +74,6 @@ protected:

bool isTextControl() const override;

// This returns true if it's focusable but it's not content editable and it's not a control or ARIA control.

bool isGenericFocusableElement() const;

- HTMLLabelElement* labelForElement(const Element*) const;

AXObject* menuButtonForMenu() const;

Element* menuItemElementForMenu() const;

Element* mouseButtonListener() const;