Source/core/loader/cache/CachedImage.cpp - Issue 19393004: Allow eviction of ImageBitmaps that are created from ImageElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/cache/CachedImage.cpp

Issue 19393004: Allow eviction of ImageBitmaps that are created from ImageElements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/cache/CachedImage.cpp

diff --git a/Source/core/loader/cache/CachedImage.cpp b/Source/core/loader/cache/CachedImage.cpp

index 05855719bd5ceee4c9cd4997782045db1aa6a210..dc9316070d8341704fc77cf7aa6c30844e5634e5 100644

--- a/Source/core/loader/cache/CachedImage.cpp

+++ b/Source/core/loader/cache/CachedImage.cpp

@@ -402,7 +402,9 @@ void CachedImage::decodedSizeChanged(const Image* image, int delta)

void CachedImage::didDraw(const Image* image)

{

- if (!image || image != m_image)

+ // FIXME: not sure if this change is valid. Since taking a subset

+ // produces a different image, m_image != image for ImageBitmaps

Justin Novosad 2013/07/19 21:09:53 We need a better condition. Something like !m_imag

+ if (!image)

return;

double timeStamp = FrameView::currentPaintTimeStamp();