Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1939273002: Remove valgrind suppressions for non-existent methods (Closed)

Created:
4 years, 7 months ago by Stephen Chennney
Modified:
4 years, 7 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove valgrind suppressions for non-existent methods None of the referenced methods exist at this time. R=bruening@chromium.org BUG=363487, 369141 Committed: https://crrev.com/fcc750b7b430443d2a6ca93e63c2f0ff351eaff0 Cr-Commit-Position: refs/heads/master@{#391812}

Patch Set 1 #

Patch Set 2 : Also suppress GDI codepath is gone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 1 chunk +0 lines, -21 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939273002/1
4 years, 7 months ago (2016-05-02 20:25:55 UTC) #2
Stephen Chennney
The methods referenced have been remamed or removed, yet the world has not collapsed. So ...
4 years, 7 months ago (2016-05-02 20:26:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 21:21:55 UTC) #5
Stephen Chennney
Not sure what bot to try this on. Ideas? I can't see what I'm doing ...
4 years, 7 months ago (2016-05-03 18:25:18 UTC) #6
Derek Bruening
I am no longer full time on Chrome so it's best in general to send ...
4 years, 7 months ago (2016-05-05 01:01:50 UTC) #7
Stephen Chennney
On 2016/05/05 01:01:50, Derek Bruening wrote: > I am no longer full time on Chrome ...
4 years, 7 months ago (2016-05-05 15:21:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939273002/20001
4 years, 7 months ago (2016-05-05 15:24:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 15:57:53 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 15:59:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcc750b7b430443d2a6ca93e63c2f0ff351eaff0
Cr-Commit-Position: refs/heads/master@{#391812}

Powered by Google App Engine
This is Rietveld 408576698