Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1939263002: EME: Correctly handle container-only contentType strings (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

EME: Correctly handle container-only contentType strings Container-only contentType strings are now only allowed if they imply a codec. Since none of the supported containers fall into this category, ignore the configuration if codecs= is not specified. For compatability with existing applications, allow (and add a deprecation message) if "audio/webm", "video/webm", "audio/mp4", or "video/mp4" are used without a codec string. Also add UMA statistics so we can tell when this exception can be removed. The UMA will log the the number of successful calls where audioCapabilities or videoCapabilities are specified, and whether the contentType string contains codecs= or not. For compatability with other browsers (which may not enforce this), the deprecation message is only generated on a successful requestMediaKeySystemAccess() call (provided the successful configuration specified a contentType without codecs=). This will allow clients to attempt requestMediaKeySystemAccess() with and without codecs= until all browsers enforce this requirement. BUG=605661 TEST=updated EME layout tests passes Review-Url: https://codereview.chromium.org/1911953003 Cr-Commit-Position: refs/heads/master@{#390711} (cherry picked from commit 1e7a1cb3a153677ad560ce47e18b4bb2b107ae32) Committed: https://chromium.googlesource.com/chromium/src/+/db386c994fe6ef71f90ecd8546290017cf00acbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -8 lines) Patch
M media/blink/key_system_config_selector.cc View 3 chunks +21 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html View 3 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 5 chunks +41 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jrummell
4 years, 7 months ago (2016-05-02 20:26:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db386c994fe6ef71f90ecd8546290017cf00acbc.

Powered by Google App Engine
This is Rietveld 408576698