chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc - Issue 1939233002: Properly detect cycles in V8ValueConverter, current impl is too strict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

Issue 1939233002: Properly detect cycles in V8ValueConverter, current impl is too strict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test, some nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

index 5d252ca9b0ca5d7b221a15eae3f80e578f49e310..25f94ac58eed1748b2f3bf44aee12a9829d0288a 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

@@ -373,9 +373,7 @@ IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest, ReusedActionInstance) {

// This navigation matches both rules.

NavigateInRenderer(tab, GURL("http://test1/"));

- // Because the declarative rules were reusing action instance, addRules will

- // fail and the page action won't be visible.

- EXPECT_FALSE(page_action->GetIsVisible(tab_id));

+ EXPECT_TRUE(page_action->GetIsVisible(tab_id));

}

// Tests that the rules are evaluated at the time they are added or removed.

« no previous file with comments | « no previous file | content/child/v8_value_converter_impl.h » ('j') | content/child/v8_value_converter_impl.cc » ('J')