Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

Issue 1939203002: Reland: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 Google Inc. All rights reserved. 2 * Copyright (c) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 27 matching lines...) Expand all
38 #include "wtf/PassRefPtr.h" 38 #include "wtf/PassRefPtr.h"
39 #include "wtf/RefCounted.h" 39 #include "wtf/RefCounted.h"
40 #include "wtf/RefPtr.h" 40 #include "wtf/RefPtr.h"
41 #include "wtf/text/CharacterNames.h" 41 #include "wtf/text/CharacterNames.h"
42 42
43 #include <hb.h> 43 #include <hb.h>
44 44
45 namespace blink { 45 namespace blink {
46 46
47 class FontPlatformData; 47 class FontPlatformData;
48 struct HarfBuzzFontData;
48 49
49 class HarfBuzzFace : public RefCounted<HarfBuzzFace> { 50 class HarfBuzzFace : public RefCounted<HarfBuzzFace> {
50 WTF_MAKE_NONCOPYABLE(HarfBuzzFace); 51 WTF_MAKE_NONCOPYABLE(HarfBuzzFace);
51 public: 52 public:
52 static const hb_tag_t vertTag;
53 static const hb_tag_t vrt2Tag;
54 53
55 static PassRefPtr<HarfBuzzFace> create(FontPlatformData* platformData, uint6 4_t uniqueID) 54 static PassRefPtr<HarfBuzzFace> create(FontPlatformData* platformData, uint6 4_t uniqueID)
56 { 55 {
57 return adoptRef(new HarfBuzzFace(platformData, uniqueID)); 56 return adoptRef(new HarfBuzzFace(platformData, uniqueID));
58 } 57 }
59 ~HarfBuzzFace(); 58 ~HarfBuzzFace();
60 59
61 // In order to support the restricting effect of unicode-range optionally a 60 // In order to support the restricting effect of unicode-range optionally a
62 // range restriction can be passed in, which will restrict which glyphs we 61 // range restriction can be passed in, which will restrict which glyphs we
63 // return in the harfBuzzGetGlyph function. 62 // return in the harfBuzzGetGlyph function.
64 hb_font_t* createFont(PassRefPtr<UnicodeRangeSet> = nullptr) const; 63 hb_font_t* getScaledFont(PassRefPtr<UnicodeRangeSet> = nullptr);
65 hb_face_t* face() const { return m_face; } 64 hb_face_t* face() const { return m_face; }
66 65
67 private: 66 private:
68 HarfBuzzFace(FontPlatformData*, uint64_t); 67 HarfBuzzFace(FontPlatformData*, uint64_t);
69 68
70 hb_face_t* createFace(); 69 hb_face_t* createFace();
70 void prepareHarfBuzzFontData();
71 71
72 FontPlatformData* m_platformData; 72 FontPlatformData* m_platformData;
73 uint64_t m_uniqueID; 73 uint64_t m_uniqueID;
74 hb_face_t* m_face; 74 hb_face_t* m_face;
75 WTF::HashMap<uint32_t, uint16_t>* m_glyphCacheForFaceCacheEntry; 75 OwnPtr<hb_font_t> m_unscaledFont;
76 OwnPtr<HarfBuzzFontData> m_harfBuzzFontData;
76 }; 77 };
77 78
78 } // namespace blink 79 } // namespace blink
79 80
80 namespace WTF { 81 namespace WTF {
81 82
82 template<typename T> struct OwnedPtrDeleter; 83 template<typename T> struct OwnedPtrDeleter;
83 template<> struct OwnedPtrDeleter<hb_font_t> { 84 template<> struct OwnedPtrDeleter<hb_font_t> {
84 STATIC_ONLY(OwnedPtrDeleter); 85 STATIC_ONLY(OwnedPtrDeleter);
85 static void deletePtr(hb_font_t* font) 86 static void deletePtr(hb_font_t* font)
86 { 87 {
87 if (font) 88 if (font)
88 hb_font_destroy(font); 89 hb_font_destroy(font);
89 } 90 }
90 }; 91 };
91 92
92 } // namespace WTF 93 } // namespace WTF
93 94
94 #endif // HarfBuzzFace_h 95 #endif // HarfBuzzFace_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698