Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1939183003: Enable credit card scanning by default (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable credit card scanning by default BUG=608388 Committed: https://crrev.com/9ff30d90f6f0ae6c0186c5bd5b88ead8a810d1ba Cr-Commit-Position: refs/heads/master@{#391073}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused include #

Patch Set 3 : Remove unused include 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
please use gerrit instead
mathp@, ptal.
4 years, 7 months ago (2016-05-02 17:39:15 UTC) #2
Mathieu
lgtm with nit https://codereview.chromium.org/1939183003/diff/1/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (left): https://codereview.chromium.org/1939183003/diff/1/components/autofill/core/browser/autofill_manager.cc#oldcode255 components/autofill/core/browser/autofill_manager.cc:255: if (base::FieldTrialList::FindFullName("CreditCardScan") == "Control" && nit: ...
4 years, 7 months ago (2016-05-02 19:44:59 UTC) #3
please use gerrit instead
Sending to cq. https://codereview.chromium.org/1939183003/diff/1/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (left): https://codereview.chromium.org/1939183003/diff/1/components/autofill/core/browser/autofill_manager.cc#oldcode255 components/autofill/core/browser/autofill_manager.cc:255: if (base::FieldTrialList::FindFullName("CreditCardScan") == "Control" && On ...
4 years, 7 months ago (2016-05-02 21:29:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939183003/40001
4 years, 7 months ago (2016-05-02 21:34:01 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 22:22:55 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 22:25:26 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9ff30d90f6f0ae6c0186c5bd5b88ead8a810d1ba
Cr-Commit-Position: refs/heads/master@{#391073}

Powered by Google App Engine
This is Rietveld 408576698