components/mus/public/cpp/window_tree_client.h - Issue 1939133002: StructTraits to map mus::mojom::Event to unique_ptr<ui::Event>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/window_tree_client.h

Issue 1939133002: StructTraits to map mus::mojom::Event to unique_ptr<ui::Event> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: todo comments + reorganize files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/public/cpp/tests/window_tree_client_unittest.cc ('K') | « components/mus/public/cpp/tests/window_tree_client_unittest.cc ('k') | components/mus/ws/test_change_tracker.h » ('j') | components/mus/ws/window_manager_state_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/cpp/window_tree_client.h

diff --git a/components/mus/public/cpp/window_tree_client.h b/components/mus/public/cpp/window_tree_client.h

index 24121322817fb9c92638ea7f76d7f380cce769a6..df2a98eaa6ee90f17e41cee12c631d531acf3975 100644

--- a/components/mus/public/cpp/window_tree_client.h

+++ b/components/mus/public/cpp/window_tree_client.h

@@ -253,9 +253,9 @@ class WindowTreeClient : public mojom::WindowTreeClient,

mojo::Array<uint8_t> new_data) override;

void OnWindowInputEvent(uint32_t event_id,

Id window_id,

- mojom::EventPtr event,

+ const std::unique_ptr<ui::Event>& event,

uint32_t event_observer_id) override;

- void OnEventObserved(mojom::EventPtr event,

+ void OnEventObserved(const std::unique_ptr<ui::Event>& event,

uint32_t event_observer_id) override;

void OnWindowFocused(Id focused_window_id) override;

void OnWindowPredefinedCursorChanged(Id window_id,

@@ -279,7 +279,8 @@ class WindowTreeClient : public mojom::WindowTreeClient,

transport_properties) override;

void WmClientJankinessChanged(ClientSpecificId client_id,

bool janky) override;

- void OnAccelerator(uint32_t id, mus::mojom::EventPtr event) override;

+ void OnAccelerator(uint32_t id,

+ const std::unique_ptr<ui::Event>& event) override;

// Overridden from WindowManagerClient:

void SetFrameDecorationValues(