Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: components/mus/public/cpp/tests/window_tree_client_private.cc

Issue 1939133002: StructTraits to map mus::mojom::Event to unique_ptr<ui::Event> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: todo comments + reorganize files Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/public/cpp/tests/window_tree_client_private.cc
diff --git a/components/mus/public/cpp/tests/window_tree_client_private.cc b/components/mus/public/cpp/tests/window_tree_client_private.cc
index c5c6dfa44267c3c821a9d0cb8861d34646f37eae..f184a0d6119dd386eb8acf5e62ad2c524b21d941 100644
--- a/components/mus/public/cpp/tests/window_tree_client_private.cc
+++ b/components/mus/public/cpp/tests/window_tree_client_private.cc
@@ -37,11 +37,11 @@ void WindowTreeClientPrivate::OnEmbed(mojom::WindowTree* window_tree) {
void WindowTreeClientPrivate::CallOnWindowInputEvent(
Window* window,
- const ui::Event& event) {
+ const std::unique_ptr<ui::Event>& event) {
const uint32_t event_id = 0u;
const uint32_t observer_id = 0u;
tree_client_impl_->OnWindowInputEvent(event_id, window->server_id(),
- mojom::Event::From(event), observer_id);
+ std::move(event), observer_id);
sky 2016/06/03 20:06:50 Does this really work? If it does, doesn't that me
Hadi 2016/06/06 13:48:32 My mistake. Fixed. (It worked, but I'm not sure wh
Hadi 2016/06/06 14:35:27 Went back to using std::move() after using pass_by
}
} // namespace mus

Powered by Google App Engine
This is Rietveld 408576698