ui/events/mojo/event.typemap - Issue 1939133002: StructTraits to map mus::mojom::Event to unique_ptr<ui::Event>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/mojo/event.typemap

Issue 1939133002: StructTraits to map mus::mojom::Event to unique_ptr<ui::Event> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: todo comments + reorganize files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//components/mus/public/interfaces/input_events.mojom"

	6 public_headers = [ "//ui/events/event.h" ]

	7 traits_headers = [ "//ui/events/mojo/event_struct_traits.h" ]

	8 deps = [

	9 "//ui/events:dom_keycode_converter",

	10 "//ui//events",

	11 ]

	12 sources = [

	13 "//ui/events/mojo/event_struct_traits.h",
	sky 2016/06/03 20:06:51 You have 2 spaces in deps, so I would assume this You have 2 spaces in deps, so I would assume this should be 2 as well. Or should the above be 4? Either way, make them consistent. Hadi 2016/06/06 13:48:32 Done. Show quoted text On 2016/06/03 20:06:51, sky wrote: > You have 2 spaces in deps, so I would assume this should be 2 as well. Or should > the above be 4? Either way, make them consistent. Done.
	14 "//ui/events/mojo/event_struct_traits.cc",

	15 ]

	16 # TODO(moshayedi): crbug.com/617167. Map mojom.Event directly to ui::Event.

	17 type_mappings = [ "mus.mojom.Event=std::unique_ptr<ui::Event>" ]

OLD	NEW