Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1939123002:
Documentation: Skia+Harfbuzz example (Closed)
|
Created:
4 years, 7 months ago by hal.canary Modified:
4 years, 7 months ago Reviewers:
bungeman-skia CC:
reviews_skia.org, behdad_google, aam Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionDocumentation: Skia+Harfbuzz example
BUG=skia:4742
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning
Committed: https://skia.googlesource.com/skia/+/5441e9f8eb23e4c019e4978db4f225a48d4e7b43
Patch Set 1 #Patch Set 2 : 2016-05-02 (Monday) 11:40:01 EDT #
Total comments: 2
Patch Set 3 : 2016-05-03 (Tuesday) 12:13:02 EDT #Messages
Total messages: 16 (9 generated)
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1939123002 ==========
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1939123002 ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning ==========
halcanary@google.com changed reviewers: + bungeman@google.com
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Please take a look. Did I use words correctly?
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning ==========
https://codereview.chromium.org/1939123002/diff/20001/site/user/tips.md File site/user/tips.md (right): https://codereview.chromium.org/1939123002/diff/20001/site/user/tips.md#newco... site/user/tips.md:175: whichever SkFontHost it is compiled with. Except for some deprecated globals we're trying to delete, there isn't any class named SkFontHost anymore. It would probably be easier to just say "and the SkTypeface can then be used to draw those glyphs", or something to that effect.
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
https://codereview.chromium.org/1939123002/diff/20001/site/user/tips.md File site/user/tips.md (right): https://codereview.chromium.org/1939123002/diff/20001/site/user/tips.md#newco... site/user/tips.md:175: whichever SkFontHost it is compiled with. On 2016/05/03 15:55:24, bungeman-skia wrote: > Except for some deprecated globals we're trying to delete, there isn't any class > named SkFontHost anymore. It would probably be easier to just say "and the > SkTypeface can then be used to draw those glyphs", or something to that effect. done
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939123002/40001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-05-03 22:14 UTC
lgtm
Message was sent while issue was closed.
Description was changed from ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning ========== to ========== Documentation: Skia+Harfbuzz example BUG=skia:4742 NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning Committed: https://skia.googlesource.com/skia/+/5441e9f8eb23e4c019e4978db4f225a48d4e7b43 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/5441e9f8eb23e4c019e4978db4f225a48d4e7b43 |
