dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart - Issue 19391004: Implement reflective access to static methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart

Issue 19391004: Implement reflective access to static methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart b/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart

index 7411bc9aec29ea998e3288ffdd487318cfd032df..51ffcfc1b7bc593802e25de4c693499527f68c32 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart

@@ -497,7 +497,9 @@ class Elements {

if (r != 0) return r;

Token positionA = a.position();

Token positionB = b.position();

- r = positionA.charOffset.compareTo(positionB.charOffset);

+ int offsetA = positionA == null ? -1 : positionA.charOffset;

+ int offsetB = positionB == null ? -1 : positionB.charOffset;

+ r = offsetA.compareTo(offsetB);

if (r != 0) return r;

r = a.name.slowToString().compareTo(b.name.slowToString());

if (r != 0) return r;

« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/js/nodes.dart » ('j') | no next file with comments »