List.unmodifiable

List.unmodifiable

Most operations don't check, that will happen as more code is updated
to a more recent sdk.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/a1fa72091ad2be244d5e6b9a43e4c30d13b4a4cb

[sra1, 2016-05-02 23:14:21]

Patchset #1 (id:1) has been deleted

[sra1, 2016-05-02 23:14:56]

sra@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-05-02 23:56:13]

https://codereview.chromium.org/1939093003/diff/20001/tool/input_sdk/lib/inte...
File tool/input_sdk/lib/internal/list.dart (right):

https://codereview.chromium.org/1939093003/diff/20001/tool/input_sdk/lib/inte...
tool/input_sdk/lib/internal/list.dart:378: external List
makeListFixedLength(List growableList);
Make this generic?
List/*<T>*/ makeListFixedLength/*<T>*/(List/*<T>*/ growableList);

This should get rid of the cast in the generated code (although DDC will pass
the type param).

https://codereview.chromium.org/1939093003/diff/20001/tool/input_sdk/lib/inte...
tool/input_sdk/lib/internal/list.dart:396: external List
makeFixedListUnmodifiable(List fixedLengthList);
Ditto?

[sra1, 2016-05-03 05:09:44]

PTAL.

The two-stage application is annoying but not as much as the cast.

[vsm, 2016-05-03 13:29:14]

lgtm!

[sra1, 2016-05-03 16:34:54]

Description was changed from

==========
List.unmodifiable

Most operations don't check, that will happen as more code is updated
to a more recent sdk.

BUG=
==========

to

==========
List.unmodifiable

Most operations don't check, that will happen as more code is updated
to a more recent sdk.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/a1fa72091ad2be244d5e6b9a43e4...
==========

[sra1, 2016-05-03 16:34:55]

Committed patchset #2 (id:40001) manually as
a1fa72091ad2be244d5e6b9a43e4c30d13b4a4cb (presubmit successful).