Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1939083002: Revert of Migrate content/common/gpu/media code to media/gpu (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate content/common/gpu/media code to media/gpu (patchset #41 id:410001 of https://codereview.chromium.org/1882373004/ ) Reason for revert: Probably caused https://crbug.com/608348 Original issue's description: > Migrate content/common/gpu/media code to media/gpu > > This is part of a gpu & media refactor to enable proper layering for Mus. See bug for details. > > BUG=586386 > > Committed: https://crrev.com/6e70beb84fe0d0a3d27e4369c8b6aaae001afb81 > Cr-Commit-Position: refs/heads/master@{#390896} > > Committed: https://crrev.com/0f54920173bda1d13e9c89c51a1995a8542c5648 > Cr-Commit-Position: refs/heads/master@{#390897} > > Committed: https://crrev.com/9204aefa88c2a7af21e288dd3f1a5b8db468002a > Cr-Commit-Position: refs/heads/master@{#390908} TBR=agrieve@chromium.org,piman@chromium.org,xhwang@chromium.org,ben@chromium.org,sadrul@chromium.org,posciak@chromium.org,jam@chromium.org,markdittmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586386 Committed: https://crrev.com/5136ee33d97ca5b6608435dab672a157d81e6232 Cr-Commit-Position: refs/heads/master@{#390936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M media/gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of Migrate content/common/gpu/media code to media/gpu
4 years, 7 months ago (2016-05-02 14:45:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939083002/1
4 years, 7 months ago (2016-05-02 14:45:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 14:46:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5136ee33d97ca5b6608435dab672a157d81e6232 Cr-Commit-Position: refs/heads/master@{#390936}
4 years, 7 months ago (2016-05-02 14:48:02 UTC) #5
Nico
4 years, 7 months ago (2016-05-02 14:57:18 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1937963002/ by thakis@chromium.org.

The reason for reverting is: The revert was incomplete 'cause the original issue
was landed in a weird way. Let's revert the revert, and then cleanly revert
everything at once later..

Powered by Google App Engine
This is Rietveld 408576698