Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1939043002:
[Interpreter] Add test expectations for layout tests (Closed)
|
Created:
4 years, 7 months ago by Michael Achenbach Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Add test expectations for layout tests
BUG=v8:4866
LOG=n
NOTRY=true
TBR=yangguo@chromium.org
Committed: https://crrev.com/37ca108f9075528848d457f8c8bb26f4a84c6be9
Cr-Commit-Position: refs/heads/master@{#35937}
Patch Set 1 #
Total comments: 4
Messages
Total messages: 17 (8 generated)
Description was changed from ========== [Interpreter] Add test expectations for layout tests BUG= ========== to ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true ==========
machenbach@chromium.org changed reviewers: + rmcilroy@chromium.org, yangguo@chromium.org
PTAL
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939043002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true ========== to ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true TBR=yangguo@chromium.org ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939043002/1
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true TBR=yangguo@chromium.org ========== to ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true TBR=yangguo@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true TBR=yangguo@chromium.org ========== to ========== [Interpreter] Add test expectations for layout tests BUG=v8:4866 LOG=n NOTRY=true TBR=yangguo@chromium.org Committed: https://crrev.com/37ca108f9075528848d457f8c8bb26f4a84c6be9 Cr-Commit-Position: refs/heads/master@{#35937} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/37ca108f9075528848d457f8c8bb26f4a84c6be9 Cr-Commit-Position: refs/heads/master@{#35937}
Message was sent while issue was closed.
https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... File tools/blink_tests/TestExpectationsIgnition (right): https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... tools/blink_tests/TestExpectationsIgnition:3: [ Linux ] inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html [ Failure ] Do we plan to sort these and attach bug numbers? For example this and two other entries here belong to https://bugs.chromium.org/p/chromium/issues/detail?id=608287 https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... tools/blink_tests/TestExpectationsIgnition:5: [ Linux ] inspector/console/console-stack-overflow.html [ Failure ] This belongs to https://bugs.chromium.org/p/v8/issues/detail?id=4981 https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... tools/blink_tests/TestExpectationsIgnition:8: [ Linux ] inspector-protocol/debugger/setScriptSource.html [ Failure ] This and some other belong to https://bugs.chromium.org/p/chromium/issues/detail?id=595681
Message was sent while issue was closed.
https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... File tools/blink_tests/TestExpectationsIgnition (right): https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... tools/blink_tests/TestExpectationsIgnition:3: [ Linux ] inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html [ Failure ] On 2016/05/03 19:57:36, Yang wrote: > Do we plan to sort these and attach bug numbers? For example this and two other > entries here belong to > https://bugs.chromium.org/p/chromium/issues/detail?id=608287 Sure go ahead. I forgot to sort. C/P from the output shell. You can prefix bug entries just like in blink's TestExpectation file.
Message was sent while issue was closed.
On 2016/05/04 07:21:21, Michael Achenbach wrote: > https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... > File tools/blink_tests/TestExpectationsIgnition (right): > > https://codereview.chromium.org/1939043002/diff/1/tools/blink_tests/TestExpec... > tools/blink_tests/TestExpectationsIgnition:3: [ Linux ] > inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html [ > Failure ] > On 2016/05/03 19:57:36, Yang wrote: > > Do we plan to sort these and attach bug numbers? For example this and two > other > > entries here belong to > > https://bugs.chromium.org/p/chromium/issues/detail?id=608287 > > Sure go ahead. I forgot to sort. C/P from the output shell. You can prefix bug > entries just like in blink's TestExpectation file. There are also Chromium bugs Mythri created for these which are blocking crbug.com/602214. We could prefix any which don't have V8 specific bugs with these. I can do this later if you don't get a chance, thanks Yang. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
