WebUI: Update Downloads to fix bug introduced by JS lifecycle controls.

WebUI: Update Downloads to fix bug introduced by JS lifecycle controls.

The patch that added JS lifecycle calls to MdDownloadsDOMHandler
broke search terms.

This patch fixes that bug and adds a test to catch regressions.

BUG=608317
Committed: https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4
Cr-Commit-Position: refs/heads/master@{#391313}

[tommycli, 2016-05-02 18:30:05]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-05-02 18:30:06]

dbeam: PTAL bug fix from JS lifecycle patch.

[Dan Beam, 2016-05-03 04:11:38]

lgtm

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (right):

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:140: }
just remove this method, IMO

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
(right):

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc:61:
handler.set_web_ui(web_ui());
why do you need to call set_web_ui here?

[tommycli, 2016-05-03 16:26:05]

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (right):

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:140: }
On 2016/05/03 04:11:38, Dan Beam wrote:
> just remove this method, IMO

Done.

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
(right):

https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc:61:
handler.set_web_ui(web_ui());
On 2016/05/03 04:11:38, Dan Beam wrote:
> why do you need to call set_web_ui here?

We must call it here because the web_ui passed in during construction is only
forwarded to the ListTracker. The web_ui() member is nullptr until we call
set_web_ui.

[tommycli, 2016-05-03 16:26:14]

dbeam: Thanks!

[tommycli, 2016-05-03 16:26:23]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 16:26:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938983003/60001

[commit-bot: I haz the power, 2016-05-03 17:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 17:15:37]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-05-03 18:38:51]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-05-03 18:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1938983003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 18:39:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938983003/60001

[commit-bot: I haz the power, 2016-05-03 18:46:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-03 18:48:24]

Description was changed from

==========
WebUI: Update Downloads to fix bug introduced by JS lifecycle controls.

The patch that added JS lifecycle calls to MdDownloadsDOMHandler
broke search terms.

This patch fixes that bug and adds a test to catch regressions.

BUG=608317
==========

to

==========
WebUI: Update Downloads to fix bug introduced by JS lifecycle controls.

The patch that added JS lifecycle calls to MdDownloadsDOMHandler
broke search terms.

This patch fixes that bug and adds a test to catch regressions.

BUG=608317

Committed: https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4
Cr-Commit-Position: refs/heads/master@{#391313}
==========

[commit-bot: I haz the power, 2016-05-03 18:48:25]

Patchset 4 (id:??) landed as
https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4
Cr-Commit-Position: refs/heads/master@{#391313}