Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1938983003: WebUI: Update Downloads to fix bug introduced by JS lifecycle controls. (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Update Downloads to fix bug introduced by JS lifecycle controls. The patch that added JS lifecycle calls to MdDownloadsDOMHandler broke search terms. This patch fixes that bug and adds a test to catch regressions. BUG=608317 Committed: https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4 Cr-Commit-Position: refs/heads/master@{#391313}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc View 1 chunk +49 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tommycli
dbeam: PTAL bug fix from JS lifecycle patch.
4 years, 7 months ago (2016-05-02 18:30:06 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (right): https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc#newcode140 chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:140: } just remove this method, IMO https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc File ...
4 years, 7 months ago (2016-05-03 04:11:38 UTC) #3
tommycli
https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (right): https://codereview.chromium.org/1938983003/diff/40001/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc#newcode140 chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:140: } On 2016/05/03 04:11:38, Dan Beam wrote: > just ...
4 years, 7 months ago (2016-05-03 16:26:05 UTC) #4
tommycli
dbeam: Thanks!
4 years, 7 months ago (2016-05-03 16:26:14 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938983003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938983003/60001
4 years, 7 months ago (2016-05-03 16:26:32 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 17:15:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938983003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938983003/60001
4 years, 7 months ago (2016-05-03 18:39:41 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-03 18:46:21 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:48:25 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cf1c3c70c29cd7b1745417fe915d2e213ab987f4
Cr-Commit-Position: refs/heads/master@{#391313}

Powered by Google App Engine
This is Rietveld 408576698