Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: tools/test.py

Issue 1938973002: Add third_party/android_tools/sdk/platform-tools to PATH if available (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.py
diff --git a/tools/test.py b/tools/test.py
index 9a32fa597bf68faeae573e8cf4e4210aeff5a12f..8db546e526412172d621bdd763ac72f9b46dc3e8 100755
--- a/tools/test.py
+++ b/tools/test.py
@@ -18,6 +18,16 @@ def Main():
dart_test_script = string.join([tools_dir, dart_script_name], os.sep)
command = [utils.CheckedInSdkExecutable(),
'--checked', dart_test_script] + args
+
+ # The testing script potentially needs the android platform tools in PATH so
+ # we do that in ./tools/test.py (a similar logic exists in ./tools/build.py).
+ android_platform_tools = os.path.normpath(os.path.join(
+ tools_dir,
+ '../third_party/android_tools/sdk/platform-tools'))
+ if os.path.isdir(android_platform_tools):
+ os.environ['PATH'] = '%s%s%s' % (
+ os.environ['PATH'], os.pathsep, android_platform_tools)
+
exit_code = subprocess.call(command)
utils.DiagnoseExitCode(exit_code, command)
return exit_code
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698