Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1938923002: Reland of Port memory.long_running_idle_gmail benchmarks to TBMv2. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, nednguyen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Port memory.long_running_idle_gmail benchmarks to TBMv2. The windows bots going purple should be fixed by https://codereview.chromium.org/1935593002/ This replaces: memory.long_running_idle_gmail_tbm with memory.long_running_idle_gmail_tbmv2 and memory.long_running_idle_gmail_background with memory.long_running_idle_gmail_background_tbmv2 BUG=607922, 593793 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449 Cr-Commit-Position: refs/heads/master@{#391205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -42 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -11 lines 0 comments Download
M tools/perf/benchmarks/memory_infra.py View 2 chunks +27 lines, -22 lines 0 comments Download
M tools/perf/page_sets/long_running_idle_google_cases.py View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
ulan
PTAL, there is no change compared to the original patch except for rebasing. The cause ...
4 years, 7 months ago (2016-05-02 10:05:50 UTC) #3
perezju
lgtm, since there were no changes from the original at https://codereview.chromium.org/1931533002/ you can TBR nednguyen ...
4 years, 7 months ago (2016-05-03 08:34:16 UTC) #4
ulan
Thanks! I added Ned to cc. Landing.
4 years, 7 months ago (2016-05-03 10:00:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938923002/1
4 years, 7 months ago (2016-05-03 10:00:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176604)
4 years, 7 months ago (2016-05-03 10:07:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938923002/1
4 years, 7 months ago (2016-05-03 10:38:26 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 12:04:30 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 12:06:07 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449
Cr-Commit-Position: refs/heads/master@{#391205}

Powered by Google App Engine
This is Rietveld 408576698