Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1938833002:
AIX: use intptr_t to cast a pointer (Closed)
|
Created:
4 years, 7 months ago by JaideepBajwa Modified:
4 years, 7 months ago CC:
JoranSiu, john.yan, michael_dawson, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAIX: use intptr_t to cast a pointer
On AIX64 pthread_t is of type unsigned int (4bytes),
using intptr_t instead when casting a pointer.
R=lpy@chromium.org, jochen@chromium.org, mbrandy@us.ibm.com
BUG=
LOG=N
Committed: https://crrev.com/8e48641cf1190e9077e17e41affeb6ab10838c74
Cr-Commit-Position: refs/heads/master@{#36141}
Patch Set 1 #
Messages
Total messages: 26 (13 generated)
PTAL
Description was changed from ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=cira@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ========== to ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=cira@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ==========
bjaideep@ca.ibm.com changed reviewers: + jochen@chromium.org, lpy@chromium.org - cira@chromium.org
Description was changed from ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=cira@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ========== to ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=lpy@chromium.org, jochen@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ==========
On 2016/05/01 22:58:43, bjaideep wrote: > PTAL Still needs review, PTAL. Thanks.
The CQ bit was checked by bjaideep@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938833002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by bjaideep@ca.ibm.com
LGTM.
The CQ bit was checked by bjaideep@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938833002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938833002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bjaideep@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938833002/1
Message was sent while issue was closed.
Description was changed from ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=lpy@chromium.org, jochen@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ========== to ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=lpy@chromium.org, jochen@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=lpy@chromium.org, jochen@chromium.org, mbrandy@us.ibm.com BUG= LOG=N ========== to ========== AIX: use intptr_t to cast a pointer On AIX64 pthread_t is of type unsigned int (4bytes), using intptr_t instead when casting a pointer. R=lpy@chromium.org, jochen@chromium.org, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/8e48641cf1190e9077e17e41affeb6ab10838c74 Cr-Commit-Position: refs/heads/master@{#36141} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8e48641cf1190e9077e17e41affeb6ab10838c74 Cr-Commit-Position: refs/heads/master@{#36141} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
