Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 19388002: test.py: Report timings by adding up the time of all commands (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b3dd50eb39902c6c7c9693e5314929b18b1159cc..e4a51d90f8616b061faf466b27a0f21dfeaec46b 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -107,7 +107,11 @@ class Command {
/** The actual command line that will be executed. */
String commandLine;
- Command(this.executable, this.arguments, [this.environment = null]) {
+ /** A descriptive name for this command. */
+ String displayName;
+
+ Command(this.displayName, this.executable,
+ this.arguments, [this.environment = null]) {
if (io.Platform.operatingSystem == 'windows') {
// Windows can't handle the first command if it is a .bat file or the like
// with the slashes going the other direction.
@@ -132,12 +136,13 @@ class CompilationCommand extends Command {
bool _neverSkipCompilation;
List<Uri> _bootstrapDependencies;
- CompilationCommand(this._outputFile,
+ CompilationCommand(String displayName,
+ this._outputFile,
this._neverSkipCompilation,
this._bootstrapDependencies,
String executable,
List<String> arguments)
- : super(executable, arguments);
+ : super(displayName, executable, arguments);
Future<bool> get outputIsUpToDate {
if (_neverSkipCompilation) return new Future.value(false);
@@ -195,7 +200,8 @@ class ContentShellCommand extends Command {
List<String> options,
List<String> dartFlags,
io.Path this.expectedOutputPath)
- : super(executable,
+ : super("content_shell",
+ executable,
_getArguments(options, htmlFile),
_getEnvironment(dartFlags));
@@ -457,6 +463,8 @@ abstract class CommandOutput {
Command get command;
+ TestCase testCase;
+
bool get incomplete;
String get result;
@@ -621,7 +629,6 @@ class CommandOutputImpl implements CommandOutput {
}
return testCase.isNegative ? !didFail : didFail;
}
-
}
class BrowserCommandOutputImpl extends CommandOutputImpl {
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698