test.py: Report timings by adding up the time of all commands

tools/testing/dart/test_progress.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_progress;
 
 import "dart:io";
 import "dart:io" as io;
 import "http_server.dart" as http_server;
 import "status_file_parser.dart";
@@ skipping 195 matching lines @@
   List<TestCase> _tests = <TestCase>[];
   DateTime _startTime;
 
   TimingPrinter(this._startTime);
 
   void done(TestCase testCase) {
     _tests.add(testCase);
   }
 
   void allDone() {
-    // TODO: We should take all the commands into account
+    Duration durationOfTest(testCase) {
+      var duration = const Duration();
+      for (var output in testCase.commandOutputs.values) {
+        duration += output.time;
+      }
+      return duration;
+    }

[kustermann, 2013/07/16 14:48:47]

This procedure will be called O(n*log n) which means that we call it quite a few
times per test. We could cache it, but looking through my performance glasses
this whole things should be changed:

We should use a MaxHeap data structure of 20 elements which would basically
reduce this to linear time. But that's for another CL I guess.

+
     Duration d = (new DateTime.now()).difference(_startTime);
     print('\n--- Total time: ${_timeString(d)} ---');
     _tests.sort((a, b) {
-      Duration aDuration = a.lastCommandOutput.time;
-      Duration bDuration = b.lastCommandOutput.time;
-      return bDuration.inMilliseconds - aDuration.inMilliseconds;
+      return
+          durationOfTest(b).inMilliseconds - durationOfTest(a).inMilliseconds;
     });
     for (int i = 0; i < 20 && i < _tests.length; i++) {
       var name = _tests[i].displayName;
-      var duration = _tests[i].lastCommandOutput.time;
+      var duration = durationOfTest(_tests[i]);
       var configuration = _tests[i].configurationString;
       print('${duration} - $configuration $name');
     }
   }
 }
 
 class StatusFileUpdatePrinter extends EventListener {
   var statusToConfigs = new Map<String, List<String>>();
   var _failureSummary = <String>[];
 
@@ skipping 300 matching lines @@
       return new VerboseProgressIndicator(startTime);
     case 'status':
       return new ProgressIndicator(startTime);
     case 'buildbot':
       return new BuildbotProgressIndicator(startTime);
     default:
       assert(false);
       break;
   }
 }