Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1938753002: OOPIF: Replicate allowFullscreen flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 24fb489c389ab6732bb56dcc8b1f9d7512ca8dd5..8762eb460fad3c5090b13381affac0d454955146 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1567,23 +1567,15 @@ void RenderFrameHostImpl::OnDidChangeSandboxFlags(
void RenderFrameHostImpl::OnDidChangeFrameOwnerProperties(
int32_t frame_routing_id,
- const blink::WebFrameOwnerProperties& frame_owner_properties) {
+ const blink::WebFrameOwnerProperties& properties) {
FrameTreeNode* child = FindAndVerifyChild(
frame_routing_id, bad_message::RFH_OWNER_PROPERTY);
if (!child)
return;
- child->set_frame_owner_properties(frame_owner_properties);
+ child->set_frame_owner_properties(properties);
- // Notify the RenderFrame if it lives in a different process from its parent.
- // These properties only affect the RenderFrame and live in its parent
- // (HTMLFrameOwnerElement). Therefore, we do not need to notify this frame's
- // proxies.
alexmos 2016/05/02 17:44:06 This isn't true for allowFullscreen, so I modified
- RenderFrameHost* child_rfh = child->current_frame_host();
- if (child_rfh->GetSiteInstance() != GetSiteInstance()) {
- child_rfh->Send(new FrameMsg_SetFrameOwnerProperties(
- child_rfh->GetRoutingID(), frame_owner_properties));
- }
+ child->render_manager()->OnDidUpdateFrameOwnerProperties(properties);
}
void RenderFrameHostImpl::OnUpdateTitle(

Powered by Google App Engine
This is Rietveld 408576698