third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp - Issue 1938753002: OOPIF: Replicate allowFullscreen flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 1938753002: OOPIF: Replicate allowFullscreen flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

index fb7c27d493e47b6d6f940c1f3da819f1d1f328b2..61b06a393572f1e03d12b0c31684176cb9adc66a 100644

--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

@@ -104,6 +104,11 @@ void HTMLIFrameElement::parseAttribute(const QualifiedName& name, const AtomicSt

m_referrerPolicy = ReferrerPolicyDefault;

if (!value.isNull())

SecurityPolicy::referrerPolicyFromString(value, &m_referrerPolicy);

+ } else if (name == allowfullscreenAttr) {

+ bool oldAllowFullscreen = m_allowFullscreen;

+ m_allowFullscreen = !value.isNull();

+ if (m_allowFullscreen != oldAllowFullscreen)

+ frameOwnerPropertiesChanged();

} else {

if (name == srcAttr)

logUpdateAttributeIfIsolatedWorldAndInDocument("iframe", srcAttr, oldValue, value);