Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1938753002: OOPIF: Replicate allowFullscreen flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index 313b10a5094220061e29e2c3109bea5f97c344c9..f3e434437ce05757cbce2784eba15f768649da24 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -58,16 +58,7 @@ static bool fullscreenIsAllowedForAllOwners(const Document& document)
return false;
for (const Frame* frame = document.frame(); frame->owner(); frame = frame->tree().parent()) {
- // TODO(alexmos): The allowfullscreen attribute will need to be
- // replicated for this to work with OOPIFs. For now, deny fullscreen
- // access inside OOPIFs until https://crbug.com/550497 is fixed.
- if (frame->owner()->isRemote())
- return false;
-
- HTMLFrameOwnerElement* owner = toHTMLFrameOwnerElement(frame->owner());
- if (!isHTMLIFrameElement(owner))
- return false;
- if (!owner->hasAttribute(allowfullscreenAttr))
+ if (!frame->owner()->allowFullscreen())
return false;
}
return true;
« no previous file with comments | « content/test/data/page_with_allowfullscreen_frame.html ('k') | third_party/WebKit/Source/core/frame/FrameOwner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698