Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 1938753002: OOPIF: Replicate allowFullscreen flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only send non-default FrameOwnerProperties to new proxies Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_proxy_host.cc
diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc
index f4ba295b7add988c7c38c4620db9f4af7ab69cf1..66ec5754c4b1e8c694af107a49c6270240ac59c8 100644
--- a/content/browser/frame_host/render_frame_proxy_host.cc
+++ b/content/browser/frame_host/render_frame_proxy_host.cc
@@ -194,6 +194,16 @@ bool RenderFrameProxyHost::InitRenderFrameProxy() {
->current_replication_state()));
render_frame_proxy_created_ = true;
+
+ // For subframes, initialize the proxy's WebFrameOwnerProperties only if they
+ // differ from default values.
+ bool should_send_properties = frame_tree_node_->frame_owner_properties() !=
+ blink::WebFrameOwnerProperties();
+ if (frame_tree_node_->parent() && should_send_properties) {
alexmos 2016/05/11 00:15:09 Just a note that after discussing this with Charli
Charlie Reis 2016/05/13 21:18:42 Acknowledged.
+ Send(new FrameMsg_SetFrameOwnerProperties(
+ routing_id_, frame_tree_node_->frame_owner_properties()));
+ }
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698