OOPIF: Replicate allowFullscreen flag.

third_party/WebKit/Source/web/WebFrame.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "public/web/WebFrame.h"
 
 #include "bindings/core/v8/WindowProxyManager.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 116 matching lines @@
     FrameOwner* owner = toImplBase()->frame()->owner();
     DCHECK(owner);
     toRemoteFrameOwner(owner)->setSandboxFlags(static_cast<SandboxFlags>(flags));
 }
 
 bool WebFrame::shouldEnforceStrictMixedContentChecking() const
 {
     return toImplBase()->frame()->securityContext()->shouldEnforceStrictMixedContentChecking();
 }
 
+void WebFrame::setFrameOwnerProperties(const WebFrameOwnerProperties& properties)
+{
+    // At the moment, this is only used to replicate frame owner properties
+    // for frames with a remote owner.
+    FrameOwner* owner = toImplBase()->frame()->owner();

[dcheng, 2016/05/19 22:12:07]

Perhaps just make this:

RemoteFrameOwner* owner = toRemoteFrameOwner(toImplBase()->frame()->owner());

owner->setScrollingMode(...);
owner->setMarginWidth(...);
etc.

[alexmos, 2016/05/19 22:56:42]

Done.

+    DCHECK(owner);
+    toRemoteFrameOwner(owner)->setScrollingMode(properties.scrollingMode);
+    toRemoteFrameOwner(owner)->setMarginWidth(properties.marginWidth);
+    toRemoteFrameOwner(owner)->setMarginHeight(properties.marginHeight);
+    toRemoteFrameOwner(owner)->setAllowFullscreen(properties.allowFullscreen);
+}
+
 WebFrame* WebFrame::opener() const
 {
     return m_opener;
 }
 
 void WebFrame::setOpener(WebFrame* opener)
 {
     if (m_opener)
         m_opener->m_openedFrameTracker->remove(this);
     if (opener)
@@ skipping 205 matching lines @@
     void WebFrame::traceFrame(VisitorDispatcher visitor, WebFrame* frame) { traceFrameImpl(visitor, frame); }                  \
     void WebFrame::traceFrames(VisitorDispatcher visitor, WebFrame* frame) { traceFramesImpl(visitor, frame); }                \
     void WebFrame::clearWeakFrames(VisitorDispatcher visitor) { clearWeakFramesImpl(visitor); }
 
 DEFINE_VISITOR_METHOD(Visitor*)
 DEFINE_VISITOR_METHOD(InlinedGlobalMarkingVisitor)
 
 #undef DEFINE_VISITOR_METHOD
 
 } // namespace blink