Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1938663002: [debugger] Add JSProxy support in Runtime::GetInternalProperties (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Add JSProxy support in Runtime::GetInternalProperties For proxy object this methods returns target value, handler object and is revoked flag. R=yangguo@chromium.org,cbruni@chromium.org BUG=chromium:588705 LOG=Y Committed: https://crrev.com/f65e06b97c273b9201d10b2c22e610ba7cd80925 Cr-Commit-Position: refs/heads/master@{#35948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M src/runtime/runtime-debug.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M test/mjsunit/mirror-object.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kozy
Please take a look. I've written this CL and then found Camillo's one and it ...
4 years, 7 months ago (2016-04-29 23:00:19 UTC) #1
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-02 13:42:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938663002/1
4 years, 7 months ago (2016-05-02 17:20:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14491)
4 years, 7 months ago (2016-05-02 17:23:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938663002/1
4 years, 7 months ago (2016-05-02 17:42:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 17:44:57 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:46:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f65e06b97c273b9201d10b2c22e610ba7cd80925
Cr-Commit-Position: refs/heads/master@{#35948}

Powered by Google App Engine
This is Rietveld 408576698